AP-25387: Replaces all usages of deprecated HubItemVersion with ItemVersion #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR replaces the deprecated HubItemVersion class with the new ItemVersion API throughout the codebase. The change updates version handling for linked components by:
- Migrating from
HubItemVersionandLinkTypeenum to newItemVersionsubclasses (CurrentState,MostRecent,SpecificVersion) - Replacing direct URI manipulation with
URLResolverUtilfor parsing and applying version information - Adding proper URI construction using
URIBuilderwith exception handling
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ChangeComponentHubVersionCommand.java | Updates version change command to use ItemVersion and URLResolverUtil for URI manipulation with error handling |
| ChangeComponentHubVersionDialog.java | Refactors dialog to use ItemVersion subclasses instead of LinkType enum and updates version parsing logic |
| ChangeComponentHubVersionAction.java | Simplifies version retrieval using URLResolverUtil.parseVersion() instead of deprecated HubItemVersion.of() |
| BulkChangeMetaNodeLinksDialog.java | Updates bulk operations to use URLResolverUtil with URIBuilder for version changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...kbench.editor/src/org/knime/workbench/editor2/commands/ChangeComponentHubVersionCommand.java
Outdated
Show resolved
Hide resolved
....workbench.editor/src/org/knime/workbench/editor2/actions/BulkChangeMetaNodeLinksDialog.java
Outdated
Show resolved
Hide resolved
3nol
force-pushed
the
todo/AP-25387-remove-deprecated-hubitemversion
branch
2 times, most recently
from
4898e8d to
64c04e1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...kbench.editor/src/org/knime/workbench/editor2/commands/ChangeComponentHubVersionCommand.java
Show resolved
Hide resolved
...orkbench.editor/src/org/knime/workbench/editor2/actions/ChangeComponentHubVersionDialog.java
Show resolved
Hide resolved
...orkbench.editor/src/org/knime/workbench/editor2/actions/ChangeComponentHubVersionDialog.java
Show resolved
Hide resolved
…ersion AP-25387 (Remove deprecated `HubItemVersion` and its `LinkType`)
3nol
force-pushed
the
todo/AP-25387-remove-deprecated-hubitemversion
branch
from
64c04e1 to
6c4769c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AP-25387 (Remove deprecated
HubItemVersionand itsLinkType)